New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better Codefix onboarding process #1156

Closed

TheAngryByrd opened this issue Sep 1, 2023 · 2 comments

Member

TheAngryByrd commented Sep 1, 2023 •

edited

Loading

Creating a codefix still seems to have a high bar to entry. We should try lowering that as much as possible.

High Level Ideas:

Have some type of scaffolding tool to generate:
- Give a name for a codefix
- Give a possible diagnostic code for a codefix
- Codefixes files in src and test
- Codefix file should:
  - filter by diagnostic code
  - be able to get the AST and use the Visitor to get at a symbol
  - return the range and a sample fix
  - comments with links to various tools/topic that may be useful for dealing with ASTs (like fantomas online tool)
- Codefix tests should
  - Be able to test against this new scaffolded codefix
  - Be focused initially so it's easy to dotnet test
  - Unsure if we should make the test pass or fail initially
- Maybe automatically add it to the LSPServers

The text was updated successfully, but these errors were encountered:

Member Author

TheAngryByrd commented Sep 1, 2023

cc @nojaf @dawedawe

nojaf mentioned this issue

Scaffold codefix #1158

Merged

3 tasks

TheAngryByrd closed this as completed

Contributor

nojaf commented Sep 8, 2023

Give a possible diagnostic code for a codefix

This would be a nice follow-up thought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment