-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LSP request cancellation seems to be causing server crashes with v0.57.0 #1009
LSP request cancellation seems to be causing server crashes with v0.57.0 #1009
Comments
I think this could be related to:
..where Ionide.LSP will now crash server on unhandled/unknown exception (TaskCanceledException?) in order to avoid accidentally serializing exception object as a response as per Ionide.LSP#29. CC @baronfel |
Is this as potentially-simple to fix as adding |
Super weird that this doesn't seem to impact ionide - I've pointed my local ionide at the 0.57.0 FSAC dll and had no change. |
Just here to confirm I have the same crash with Emacs with v0.57 as @razzmatazz |
not sure if related, but I see that FSAC has downgraded Ionide.LSP to 0.4.4 on this release |
Oh geez, that's probably it then - lost the LSP upgrade on the churn of getting the proj-info dependency updated. |
@razzmatazz wait, I see 0.4.7 of Ionide.LSP in the latest FSAC:
|
oh right.. sorry, I noticed this commit a8d1172 but not the upgrade one later, sorry so this is as problem w/ current/master Ionide.LSP |
looks good now |
Started happening with v0.57.0
The cause seems to be cancelation requests (
$/cancelRequest
) from LSP client. This basically makes v0.57.0 unusable on emacs asemacs/lsp-mode
actively cancels requests when things come out of view and results are not needed anymore or UI actions are cancelled by user directly.I have this on my LSP trace log:
The text was updated successfully, but these errors were encountered: