Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure to load snapshot list (possibly more) with NodeJS >= 8.1 #60

Closed
vain opened this issue Jun 23, 2017 · 4 comments
Closed

Failure to load snapshot list (possibly more) with NodeJS >= 8.1 #60

vain opened this issue Jun 23, 2017 · 4 comments

Comments

@vain
Copy link
Contributor

vain commented Jun 23, 2017

Calling profitbricks snapshot list simply yields an empty output when using NodeJS 8.1. Worked fine with previous versions of NodeJS.

Let me know if you can't reproduce this and/or if you need more information to debug.

@vain
Copy link
Contributor Author

vain commented Jun 23, 2017

Note: There might be more issues with recent versions of NodeJS. Didn't investigate further.

@edevenport
Copy link
Contributor

edevenport commented Jun 27, 2017

Thank you for reporting the issue @vain

I have merged a PR into master that should address this issue. A third-party module called console.table was being used to render the output as a table. It seems that NodeJS v8.x now reserves the console.table namespace. Though, it is now reserved, it's not actually used and simply returns undefined.

I was able to work around this by first deleting the internal module and overriding it with the third-party module. We should implement a better long-term solution, but this should correct the issue for now. Can you confirm? If everything is working as expected, then I can tag a release and push to NPM later today.

@edevenport
Copy link
Contributor

I have been running the automated tests on both NodeJS v6.11.x and v8.1.2. Both are passing now so I went ahead and tagged release v3.1.0 and pushed to NPM. If you still encounter problems, please feel free to reopen this issue.

@vain
Copy link
Contributor Author

vain commented Jun 28, 2017

Hi,

yes, works like a charm now.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants