Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unary minus (and negate) are incorrect for ModularBigInteger #292

Closed
iaik-jheher opened this issue May 23, 2024 · 0 comments · Fixed by #293
Closed

Unary minus (and negate) are incorrect for ModularBigInteger #292

iaik-jheher opened this issue May 23, 2024 · 0 comments · Fixed by #293

Comments

@iaik-jheher
Copy link
Contributor

ModularBigInteger::negate simply returns this. It should return the additive inverse (modulus - residue).

MWE:

val creator = ModularBigInteger.creatorForModulo(7)
val a = creator.fromInt(6)
val b = creator.fromInt(3)
require ((a-b) == (a+(-b)))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix modular additive inverse
1 participant
@iaik-jheher