fix(uploads): fix buffer that is sent to s3 (#60)

fix #59
iopipe · Jul 27, 2018 · 90e24f2 · 90e24f2
1 parent f59c22d
commit 90e24f2
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 6 deletions.
diff --git a/src/index.js b/src/index.js
@@ -108,8 +108,15 @@ class ProfilerPlugin {
 
   getFileUploadMeta() {
     // returns a promise here
+    const {
+      invokedFunctionArn: arn,
+      awsRequestId: requestId
+    } = this.invocationInstance.context;
+
     return coreUtil.getFileUploadMeta({
-      auth: this.token
+      auth: this.token,
+      arn,
+      requestId
     });
   }
 
@@ -122,7 +129,9 @@ class ProfilerPlugin {
         this.uploads.push(fileUploadMeta.jwtAccess);
         this.signedRequestUrl = fileUploadMeta.signedRequest;
       } else {
-        return this.log(`S3 signer service error. Response: ${fileUploadMeta}`);
+        return this.log(
+          `S3 signer service error. Response: ${JSON.stringify(fileUploadMeta)}`
+        );
       }
     } catch (err) {
       this.log(err);
@@ -151,7 +160,7 @@ class ProfilerPlugin {
           await request({
             url: this.signedRequestUrl,
             method: 'PUT',
-            body: Buffer.concat(archiveBuffer).toString()
+            body: Buffer.concat(archiveBuffer)
           });
           resolve();
         });

diff --git a/src/index.test.js b/src/index.test.js
@@ -76,17 +76,17 @@ async function runFn(opts, fn = (e, ctx) => ctx.succeed('pass')) {
 test('Works with profiler enabled', async function runTest() {
   await runFn({ enabled: true });
   expect(putData).toHaveLength(1);
-  expect(putData[0].toString()).toMatch(/profile\.cpuprofile/);
+  expect(putData[0].toString().length).toBeGreaterThan(1000);
 });
 
 test('Works with heapSnapshot enabled', async function runTest() {
   await runFn({ heapSnapshot: true });
   expect(putData).toHaveLength(1);
-  expect(putData[0].toString()).toMatch(/profile\.heapsnapshot/);
+  expect(putData[0].toString().length).toBeGreaterThan(1e6);
 });
 
 test('Works with both enabled', async function runTest() {
   await runFn({ enabled: true, heapSnapshot: true });
   expect(putData).toHaveLength(1);
-  expect(putData[0].toString()).toMatch(/cpuprofile[^]+heapsnapshot/);
+  expect(putData[0].toString().length).toBeGreaterThan(1e6);
 });