Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use S3 signer code from js-core #57

Closed
coreylight opened this issue Jul 6, 2018 · 0 comments · Fixed by #58
Closed

Use S3 signer code from js-core #57

coreylight opened this issue Jul 6, 2018 · 0 comments · Fixed by #58
Assignees
@coreylight

Comments

@coreylight
Copy link
Contributor

When this is complete:
iopipe/iopipe-js-core#277

The code to interact with the S3 signer should be deprecated and switched to the core utility.
@coreylight coreylight self-assigned this Jul 6, 2018
coreylight added a commit to coreylight/iopipe-plugin-profiler that referenced this issue Jul 6, 2018
@coreylight
refactor(s3 signer util): use util from core
ec7df60 
Also moves the signer request to pre:invoke hook for faster resolution

fix iopipe#57
@coreylight coreylight mentioned this issue Jul 6, 2018
Merged
coreylight added a commit that referenced this issue Jul 18, 2018
@coreylight
fix(upload request): start s3 signer request earlier in pre:invoke
f59c22d 
- refactor(s3 signer util): use util from core

fix #57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coreylight coreylight

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(s3 signer util): use util from core coreylight/iopipe-plugin-profiler
1 participant
@coreylight