Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builder: assert nonnegative values #1

Open
yurivish opened this issue Mar 27, 2024 · 0 comments
Open

builder: assert nonnegative values #1

yurivish opened this issue Mar 27, 2024 · 0 comments

Comments

@yurivish
Copy link
Collaborator

https://github.com/iopsystems/h2-histogram-js/blob/main/src/index.js#L280

this would serve as a sanity check for subtraction of rolling histograms.

(and in fact, we will need to be exceedingly careful about exposing rolling histograms to the front-end since in their default representation they rely on u64 overflow behavior which means that deltas must be taken in that representation, with the result represented as a u64 or otherwise handling the overflow with a mod operation.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant