Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secret/public key wrapper guidelines #144

Open
semenov-vladyslav opened this issue May 26, 2022 · 0 comments
Open

Secret/public key wrapper guidelines #144

semenov-vladyslav opened this issue May 26, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@semenov-vladyslav
Copy link
Collaborator

semenov-vladyslav commented May 26, 2022

Description

Secret/public key wrapper guidelines are needed: naming convention, interoperability traits, security concerns.

Motivation

Wrappers for asymmetric and secret keys are common (ed25519, x25519, slip10). Often they use different names and argument/result types to do the same task and implement (or not) different traits, this is inconvenient. Also, secret key bytes can be leaked via local variables which is discouraged.

Requirements

This issue should introduce a guideline (maybe, a wiki page) and check the current implementations for conformance. A draft can be found here: wrappers-guidelines.

Are you planning to do it yourself in a pull request?

Yes.

@semenov-vladyslav semenov-vladyslav added the enhancement New feature or request label May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant