Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SDK extensible #1519

Open
Dr-Electron opened this issue Oct 26, 2023 · 3 comments
Open

Make SDK extensible #1519

Dr-Electron opened this issue Oct 26, 2023 · 3 comments
Labels
dx-improvement Mainly for DX team itself to track issues with features/fixes that improve dx m-wallet Module - Wallet t-investigate Task - Investigation

Comments

@Dr-Electron
Copy link
Contributor

Description

For external libraries/applications to use the SDK for their specific use case it would be nice to have interfaces in the SDK that can be extended.

Examples:

  • Extend accounts to have custom send functions
  • Extend the Secret manager
  • Extend storage (custom DB)

Motivation

  • Use cases like identity often have their own key management like we can also see here.

  • Some use cases might need different storage interfaces like we can see here.

Open questions (optional)

Tbh I have no clue how complicated this would be for bindings...

Are you planning to do it yourself in a pull request?

No

@Thoralf-M
Copy link
Member

Please open own issues for specific things to do

@Dr-Electron
Copy link
Contributor Author

I just wanted to get your opinion first as see (now) that there are a lot of moving components. Seems like you already (are working on) use traits in different places so that should be nice.

What about bindings? Should we find a way to extend those?

@thibault-martinez thibault-martinez added m-wallet Module - Wallet t-investigate Task - Investigation dx-improvement Mainly for DX team itself to track issues with features/fixes that improve dx labels Oct 29, 2023
@thibault-martinez thibault-martinez added this to the v2.0.0 milestone Oct 29, 2023
@Thoralf-M
Copy link
Member

Thoralf-M commented Nov 3, 2023

For things where we have traits we could maybe implement them from bindings via closures. I did some experimentation with the StorageAdapter trait and nodejs here Thoralf-M@bf43fb3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx-improvement Mainly for DX team itself to track issues with features/fixes that improve dx m-wallet Module - Wallet t-investigate Task - Investigation
Projects
Status: External Backlog
Status: Product Backlog
Development

No branches or pull requests

3 participants