Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide how to deal with the different transaction states #1814

Open
Thoralf-M opened this issue Jan 9, 2024 · 0 comments
Open

Decide how to deal with the different transaction states #1814

Thoralf-M opened this issue Jan 9, 2024 · 0 comments
Assignees
Labels
m-wallet Module - Wallet

Comments

@Thoralf-M
Copy link
Member

Thoralf-M commented Jan 9, 2024

Description

For example here

// TODO: Separate TransactionState::Finalized, TransactionState::Accepted?
TransactionState::Finalized
| TransactionState::Accepted
| TransactionState::Confirmed => {

Should the inputs of a tx only be removed form the locked_outputs if it's finalized? Because if it's happening earlier, the indexer still provides the outputs as unspent and then it could lead to conflicting txs?
Do we update the InclusionState to also have Accepted and Finalized?
Do we also need other events than just TransactionInclusion?

@Thoralf-M Thoralf-M added this to the v2.0.0 milestone Jan 9, 2024
@Thoralf-M Thoralf-M added the m-wallet Module - Wallet label Jan 9, 2024
@thibault-martinez thibault-martinez self-assigned this Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
m-wallet Module - Wallet
Projects
Status: Sprint Backlog
Development

No branches or pull requests

2 participants