Skip to content
This repository has been archived by the owner on Aug 23, 2020. It is now read-only.

Validate bundles as they come in #1810

Open
GalRogozinski opened this issue Mar 26, 2020 · 2 comments · May be fixed by #1820
Open

Validate bundles as they come in #1810

GalRogozinski opened this issue Mar 26, 2020 · 2 comments · May be fixed by #1820
Assignees
Milestone

Comments

@GalRogozinski
Copy link
Contributor

Description

We want to validate bundles as they come in and not only on tip-selection and milestone solidification

Motivation

As part of the white-flag changes we are doing now, we expect very little of the tangle to be left-behind. So it makes sense to validate as they arrive. We can use the validation status to give the proper score to a tip in #1771

Requirements

  1. When a tail solidifies, and all the bundles it approves are valid, pass it on to bundle validation
  2. We have 3 possible validity statuses on a tail: INVALID, VALID, and UNKNOWN (we currently have this). Once a tail changes its status from UNKNOWN->VALID we start propagating the check upwards to the approvers. If it changes its status from UNKNOWN->INVALID, propagate the status to the approvers.
@GalRogozinski GalRogozinski added C-Validation L-Groom This issue needs to be groomed labels Mar 26, 2020
@GalRogozinski
Copy link
Contributor Author

We should add a bundle validation stage after the solidification stage (if it exists)
or if not ready after received stage.
Currently this stage will not be a prerequisite to any other stages.
In Later issues we may change this so we only broadcast valid bundles (but not now)

@GalRogozinski GalRogozinski removed the L-Groom This issue needs to be groomed label Mar 26, 2020
@GalRogozinski GalRogozinski added this to the Mardi Gras milestone Mar 30, 2020
@acha-bill acha-bill self-assigned this Mar 31, 2020
@acha-bill acha-bill linked a pull request Mar 31, 2020 that will close this issue
6 tasks
@acha-bill
Copy link
Contributor

This is blocked by #1805 and #1821

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants