Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and cleanup go.mod #646

Closed
ethanfrey opened this issue May 20, 2019 · 0 comments · Fixed by #668
Closed

Review and cleanup go.mod #646

ethanfrey opened this issue May 20, 2019 · 0 comments · Fixed by #668
Assignees

Comments

@ethanfrey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
A look at go.mod diffs after a recent PR #663 showed a number of changes in "indirect" packages. Also many dependencies that were unexpected.

Describe the solution you'd like
Let's go through and make sure nothing unnecessary is in this. We also should reflect on how we handle versioning for tools (like prototool). There are interesting related discussions in golang/go#25922 and golang/go#27653

In particular golang/go#25922 (comment) seems like a proper solution here and may allow us to reduce the surface of go.mod.

Additional context
There is likely some overlap with other protobuf tooling cleanup in #629

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant