-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PCA looks different on current R #74
Comments
Hi, to document the progress of catching this, it is not the actual calculation of the PCA that causes the difference. Line 856 in 5348757
So for 3.6.3 we get
And for 4.3.2 we get for the same input
And already the input data to processing is different: Line 732 in 5348757
3.6.3:
4.3.2:
The data is originally loaded into the
4.3.2
The difference is already present in Line 706 in 5348757
where the input parameter metaboliteProfile is identical, but the resulting matrixDataFrame() differs:Line 804 in 5348757
It seems we are getting (vastly!) different results depending on how we convert from string input to numbers:
|
So, starting a new comment, as we don't need the code in the MetFamily shiny app anymore, and not even the MetFamily container. The issue is already in the The minimum reproducible example needs the attached Rdata file (do not uncompress! The .gz ending is only to make GitHub happy !) in the current directory And run it in the shiny containers with different base versions:
And the broken 4.3.2:
|
So, I pinpointed the changed bevaviour to https://cran.r-project.org/bin/windows/base/old/4.0.0/NEWS.R-4.0.0.html
=> Now we need to fix MetFamily, occurrences of |
Hi,
when switching from R underneath MetFamily from R-3.6.3 to R-4.X, the PCA looks different:
R-3.6.3 gives:
but R-4.X gives something different: (both 4.0.5 and 4.3.2 give identical result)
@khabatv identified (thanks!) that the function has switched the default method (SVD, EVD), so it should help to explicitly specify the method in
MetFamily/R/Analysis.R
Line 838 in 25c56c4
Yours,
Steffen
The text was updated successfully, but these errors were encountered: