-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update APIs #10
Comments
Minimum version of webchem needed has to be newer than 04.08.2020, |
Currently this fails with
since a ChemSpider token needs to be provided. The above is used in RMassBank_mFam/galaxy/msp2massbank.r Line 128 in be16fc7
=> I suggest to use a non-web service to convert that. Yours, Steffen |
I tested the |
There are several APIs that needs to be updated. They perform queries to online web services and were outdated. I fixed a bunch 3 months ago. These were the
cs_inchikey_inchi
-like function calls of the packagewebchem
. They are now aggregated in one large function calledcs_convert
. It took me a while to discover that as the calls have been deprecated in the package without mentioning... An example is here in the latest commit:https://github.com/korseby/RMassBank_mFam/blob/d29742edfd676dd1452aae774eb05d68cf9eb94c/galaxy/msp2massbank.r#L127
I suggest to take the version from one year ago as a reference as this is the version that has been known to work underlying the Docker image on dockerhub.
https://github.com/korseby/RMassBank_mFam/blob/93580571e7958175b955adf7efe13d7f0acb0c9b/galaxy/msp2massbank.r
https://hub.docker.com/r/korseby/msp2massbank
If you have questions, please mention me directly at github so I can help.
The text was updated successfully, but these errors were encountered: