Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtfs2gps() - possible bug with filter_week_days() #124

Closed
pedro-andrade-inpe opened this issue May 13, 2020 · 1 comment
Closed

gtfs2gps() - possible bug with filter_week_days() #124

pedro-andrade-inpe opened this issue May 13, 2020 · 1 comment

Comments

@pedro-andrade-inpe
Copy link
Collaborator

Filtering with filter_week_days() requires remove_invalid() to make gtfs2gps() working properly. The following code works:

  fortaleza <- system.file("extdata/fortaleza.zip", package="gtfs2gps")

  gtfs <- read_gtfs(fortaleza) %>%
    filter_week_days() %>% 
    remove_invalid()
  
  fortaleza_gps <- gtfs2gps(gtfs, progress = FALSE)

The following code stops with an error:

  fortaleza <- system.file("extdata/fortaleza.zip", package="gtfs2gps")

  gtfs <- read_gtfs(fortaleza) %>%
    filter_week_days()
  
  fortaleza_gps <- gtfs2gps(gtfs, progress = FALSE)
@pedro-andrade-inpe
Copy link
Collaborator Author

The code above does not produce an error anymore, only two warnings related to shape ids that have zero stops. As we have decided not to remove_invalid automatically, I have just updated the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant