Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[venus-sector-manager] util worker list debug日志 --net=cali时,打印为主网? #384

Closed
1 of 4 tasks
Tracked by #5625
Fatman13 opened this issue Aug 15, 2022 · 5 comments
Closed
1 of 4 tasks
Tracked by #5625
Labels
bug Something isn't working P3 Low - not important right now
Milestone

Comments

@Fatman13
Copy link
Contributor

模块 / Components

  • venus-sector-manager
  • venus-worker
  • 工具链 / toolchains
  • 文档 / docs

版本 / Version

起因:https://filecoinproject.slack.com/archives/C028PCH8L31/p1660448083060089

描述 / Describe the Bug

util worker list debug日志 --net=cali时,打印为主网?

image

venus-sector-manager --net=cali daemon run --poster --miner

日志 / Logging Information

root@200-18:~/baiyu/venus-cluster/dist/bin# ./venus-sector-manager util worker list
2022-08-15T16:31:37.151+0800	DEBUG	policy	policy/const.go:20	NETWORK SETUP	{"name": "mainnet"}
Name     Dest             Threads  Empty  Paused  Errors  LastPing(with ! if expired)
amd-ext  127.0.0.1:17891  1        0      0       0       112h52m21.177836394s (!)


### 重现步骤 / Repo Steps

_No response_
@Fatman13 Fatman13 added the bug Something isn't working label Aug 15, 2022
@cloudxin
Copy link
Contributor

可以考虑新增一个环境变量,来指定链服务所处的网络

每条命令都需要使用--net cali是多余的

image

@Fatman13
Copy link
Contributor Author

原来是这样。。

@dtynn
Copy link
Contributor

dtynn commented Aug 19, 2022

关于这个问题,比较好的做法是直接使用上游 venus 节点的网络设置和参数。
目前,这个做法存在一些阻碍,如下:

  • 网络参数设置发生在 CLI 的初始化环节,而venus client 通常在具体命令里才会构造
  • 事件发生的先后顺序,在有些场景中可能导致产生结果的迥异,这点我们需要仔细检查排除

这个 issue 很有意义,但我们可能需要更多的准备来提供一个优雅的实现。
在那之前,可能隐去相关的 log 有助于避免用户的困扰?😂

@dtynn dtynn added the P3 Low - not important right now label Aug 19, 2022
@Fatman13
Copy link
Contributor Author

嗯。先隐去也不错?

@0x5459
Copy link
Collaborator

0x5459 commented Jan 16, 2023

ref #562

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P3 Low - not important right now
Projects
No open projects
Status: Done
Development

No branches or pull requests

4 participants