Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use sdk patch but not maintain full tinygo #52

Closed
hunjixin opened this issue Jul 26, 2022 · 2 comments · Fixed by #56
Closed

use sdk patch but not maintain full tinygo #52

hunjixin opened this issue Jul 26, 2022 · 2 comments · Fixed by #56
Assignees
@hunjixin
Labels
C-enhancement Category - New feature or request P1 High - we should be working on this now or in the immediate future

Comments

@hunjixin
Copy link
Contributor

go not support std replace, and this proposal still in incoming golang/go#30241,

so use patch for reflect patch for tinygo and fmt patch for go. and than sdk could only maintain a minor patch.
@hunjixin hunjixin changed the title use sdk patch but not maintain tinygo sdk use sdk patch but not maintain full tinygo Jul 26, 2022
@hunjixin
Copy link
Contributor Author

refer https://github.com/docker/go/blob/master/Makefile

@hunjixin
Copy link
Contributor Author

patch generate and apply https://gist.github.com/nepsilon/22bc62a23f785716705c

@hunjixin hunjixin moved this to Backlog in go-fvm-sdk Jul 27, 2022
@hunjixin hunjixin added C-enhancement Category - New feature or request P1 High - we should be working on this now or in the immediate future labels Jul 27, 2022
@hunjixin hunjixin moved this from Backlog to Todo in go-fvm-sdk Jul 27, 2022
@hunjixin hunjixin mentioned this issue Aug 10, 2022
Merged
@hunjixin hunjixin self-assigned this Aug 10, 2022
Repository owner moved this from Todo to Done in go-fvm-sdk Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hunjixin hunjixin

Labels
C-enhancement Category - New feature or request P1 High - we should be working on this now or in the immediate future
Projects
go-fvm-sdk
Status: Done
Milestone
No milestone
1 participant
@hunjixin