Refactor tar-stream-to-objects to better show intent

Author: haadcode

src/api/get.js

@@ -33,6 +33,6 @@ module.exports = (send) => {
     }
 
     // Convert the response stream to TarStream objects
-    send.andTransform(request, TarStreamToObjects.from, callback)
+    send.andTransform(request, TarStreamToObjects, callback)
   })
 }

src/tar-stream-to-objects.js

@@ -2,44 +2,45 @@
 
 const tar = require('tar-stream')
 const ReadableStream = require('readable-stream').Readable
-/*
-  Transform tar stream into a stream of objects:
 
-  Output format:
-  { path: 'string', content: Readable }
-*/
-class TarStreamToObjects extends ReadableStream {
+class ObjectsStreams extends ReadableStream {
   constructor (options) {
     const opts = Object.assign(options || {}, { objectMode: true })
     super(opts)
   }
 
-  static from (inputStream, callback) {
-    let outputStream = new TarStreamToObjects()
-
-    inputStream
-      .pipe(tar.extract())
-      .on('entry', (header, stream, next) => {
-        stream.on('end', next)
-
-        if (header.type !== 'directory') {
-          outputStream.push({
-            path: header.name,
-            content: stream
-          })
-        } else {
-          outputStream.push({
-            path: header.name
-          })
-          stream.resume()
-        }
-      })
-      .on('finish', () => outputStream.push(null))
-
-    callback(null, outputStream)
-  }
+  _read ()  {}
+}
 
-  _read () {}
+/*
+  Transform a tar stream into a stream of objects:
+
+  Output format:
+  { path: 'string', content: Stream<Readable> }
+*/
+const TarStreamToObjects = (inputStream, callback) => {
+  let outputStream = new ObjectsStreams()
+
+  inputStream
+    .pipe(tar.extract())
+    .on('entry', (header, stream, next) => {
+      stream.on('end', next)
+
+      if (header.type !== 'directory') {
+        outputStream.push({
+          path: header.name,
+          content: stream
+        })
+      } else {
+        outputStream.push({
+          path: header.name
+        })
+        stream.resume()
+      }
+    })
+    .on('finish', () => outputStream.push(null))
+
+  callback(null, outputStream)
 }
 
 module.exports = TarStreamToObjects