fix: css styles applied & config page collapse #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SgtPooki
commented
Mar 14, 2024
Comment on lines
+18
to
+23
| it('has css file with expected content', async () => { | ||
| await expect(access(resolve(cwd, '../dist/ipfs-sw-styles.css'), constants.F_OK)).to.not.be.rejected() | ||
| const contents = await readFile(resolve(cwd, '../dist/ipfs-sw-styles.css'), 'utf8') | ||
| expect(contents).to.include('47vh') | ||
| expect(contents).to.include('.local-storage-toggle input.status') | ||
| }) |
There was a problem hiding this comment.
we will likely want to remove this in the future but i'm going to leave it for now
Comment on lines
+70
to
+72
| "sideEffects": [ | ||
| "*.css" | ||
| ] |
There was a problem hiding this comment.
needed this to tell webpack about our css (tree splitting was ignoring css files because we told it we had no side effects..).
IIUC this is a webpack specific thing. see https://webpack.js.org/guides/tree-shaking/#mark-the-file-as-side-effect-free
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Fix css styles not being included in final assets & better config page handling
Description
If a user explicitly wants to see the config from the subdomain, it should not be collapsed by default. Will update shortly.This will be done in a separate PR. see feat: explicit subdomain request to view config page should not be collapsed by default #113fixes #111
Notes & open questions
Change checklist