Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update country/region names #78

Merged
merged 2 commits into from
Sep 1, 2020
Merged

Conversation

raulk
Copy link
Contributor

@raulk raulk commented Sep 1, 2020

  • Corrects the spelling of the city of Melilla (Spain).
  • Uses South/North Korea familiar denomination for those countries, which are probably less politically charged than the formal names. Google, Twitter et al use that terminology. Screenshots attached from Twitter, Google, Facebook.

Screenshot 2020-09-01 at 20 36 34

Screenshot 2020-09-01 at 20 23 54

image

@raulk
Copy link
Contributor Author

raulk commented Sep 1, 2020

I have no clue why this straightforward CI build fails 🤷‍♂️

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @raulk

  • CI fails because your commit did not start with fix:
    (seems to annoy more than being useful, perhaps its time to disable this check for this repo)
  • this PR needs npm run generate to rebuild new dataset with fixed names, and then updating src/lookup.js – I will do this shortly and then cut a new release

ps. do you know the source of data used by those services?
(We would love to outsource this type of decisions when possible)

@lidel lidel changed the title update country/region names. fix: update country/region names. Sep 1, 2020
raulk and others added 2 commits September 1, 2020 22:11
License: MIT
Signed-off-by: Marcin Rataj <lidel@lidel.org>
License: MIT
Signed-off-by: Marcin Rataj <lidel@lidel.org>
@lidel lidel changed the title fix: update country/region names. fix: update country/region names Sep 1, 2020
@lidel lidel merged commit d27807d into ipfs-shipyard:master Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants