Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to dag-cbor #85

Closed
lidel opened this issue Dec 16, 2021 · 0 comments · Fixed by #93
Closed

Switch to dag-cbor #85

lidel opened this issue Dec 16, 2021 · 0 comments · Fixed by #93
Labels
exp/intermediate Prior experience is likely helpful help wanted Seeking public contribution on this issue P1 High: Likely tackled by core team if no one steps up

Comments

@lidel
Copy link
Member

lidel commented Dec 16, 2021 •
edited
Loading

Problem

This library is very old, and remembers the time before we had dag-cbor.
It uses stringified JSON put in data field of dag-pb which is not only inefficiency and a technical debt, but an antipattern these days.

Solution
@lidel lidel added help wanted Seeking public contribution on this issue P1 High: Likely tackled by core team if no one steps up exp/intermediate Prior experience is likely helpful labels Dec 16, 2021
@lidel lidel mentioned this issue Jun 6, 2022
Open
@lidel lidel mentioned this issue Jun 29, 2022
Merged
@lidel lidel mentioned this issue Sep 6, 2022
Merged
21 tasks
@lidel lidel closed this as completed in #93 Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
exp/intermediate Prior experience is likely helpful help wanted Seeking public contribution on this issue P1 High: Likely tackled by core team if no one steps up
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: switch to DAG-CBOR ipfs-shipyard/ipfs-geoip
1 participant
@lidel