Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: ls size and cumulative size #4

Open
alanshaw opened this issue Oct 25, 2018 · 0 comments
Open

RFC: ls size and cumulative size #4

alanshaw opened this issue Oct 25, 2018 · 0 comments

Comments

@alanshaw
Copy link
Member

The current rationale wants ls size to be the TOTAL size of the node and it's children including any protobuf wrappers. There is existing a cumulativeSize field and I think that we should use this field to convey that information and use size to be the size of the data contained in the node and any of it's children i.e. excluding protobuf wrappers.
@alanshaw alanshaw changed the title ls size and cumulative size RFC: ls size and cumulative size Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alanshaw