Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support config files #102

Merged
merged 4 commits into from
May 14, 2019
Merged

feat: support config files #102

merged 4 commits into from
May 14, 2019

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented May 14, 2019

This PR adds the rc package which with one line allows us to have configuration files so we don't need to set all flags we want every time we run the CLI.

The application name is ipfsnpm, hence it will look for a configuration file on the following paths:

  1. ./.ipfsnpmrc
  2. $HOME/.ipfsnpmrc
  3. $HOME/.ipfsnpm/config
  4. $HOME/.config/ipfsnpm
  5. $HOME/.config/ipfsnpm/config
  6. /etc/ipfsnpmrc
  7. /etc/ipfsnpm/config

This will help us with adding npm-on-ipfs support on IPFS desktop by letting us easily configure which daemon to use by default (see ipfs/ipfs-desktop#911).

This also closes #83.

License: MIT
Signed-off-by: Henrique Dias hacdias@gmail.com

hacdias added 2 commits May 14, 2019 07:57
License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
@hacdias hacdias requested a review from achingbrain May 14, 2019 07:07
@ghost ghost assigned hacdias May 14, 2019
@ghost ghost added the status/in-progress In progress label May 14, 2019
README.md Outdated Show resolved Hide resolved
src/cli/bin.js Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
@hacdias
Copy link
Member Author

hacdias commented May 14, 2019

@achingbrain updated!

README.md Outdated Show resolved Hide resolved
License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
@achingbrain achingbrain merged commit 877840b into master May 14, 2019
@achingbrain achingbrain deleted the feat/support-config-files branch May 14, 2019 10:09
@ghost ghost removed the status/in-progress In progress label May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save preference for --ipfs-node
2 participants