Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preparations for js-ipfs 0.31 #22

Closed
alanshaw opened this issue Jul 28, 2018 · 1 comment
Closed

preparations for js-ipfs 0.31 #22

alanshaw opened this issue Jul 28, 2018 · 1 comment

Comments

@alanshaw
Copy link
Member

I upgraded the ipfs dependencies in preparation for js-ipfs 0.31, and ran the e2e tests from peer-pad and they failed :(

ipfs/js-ipfs#1458

$ DEBUG=true npm run test:e2e

> peerpad@0.1.0 test:e2e /Users/alan/Code/protocol-labs/peer-pad
> jest --testMatch **/test/e2e/**/*.js

  console.log test/e2e/smoke.test.js:9
    Testing http://localhost:3000

 FAIL  test/e2e/smoke.test.js (254.534s)
  ● creates a pad

    waiting for selector "[data-peer-id]" failed: timeout 120000ms exceeded
      
      at new WaitTask (node_modules/puppeteer/lib/FrameManager.js:840:28)
      at Frame._waitForSelectorOrXPath (node_modules/puppeteer/lib/FrameManager.js:731:12)
      at Frame.waitForSelector (node_modules/puppeteer/lib/FrameManager.js:690:17)
      at Page.waitForSelector (node_modules/puppeteer/lib/Page.js:1008:29)
      at waitForPeerId (test/e2e/smoke.test.js:103:14)
      at Object.<anonymous>.it (test/e2e/smoke.test.js:49:24)

  ● synchronises two pads via IPFS

    waiting for selector "[data-peer-id]" failed: timeout 120000ms exceeded
      
      at new WaitTask (node_modules/puppeteer/lib/FrameManager.js:840:28)
      at Frame._waitForSelectorOrXPath (node_modules/puppeteer/lib/FrameManager.js:731:12)
      at Frame.waitForSelector (node_modules/puppeteer/lib/FrameManager.js:690:17)
      at Page.waitForSelector (node_modules/puppeteer/lib/Page.js:1008:29)
      at waitForPeerId (test/e2e/smoke.test.js:103:14)
      at Object.<anonymous>.it (test/e2e/smoke.test.js:63:27)

  ✕ creates a pad (127338ms)
  ✕ synchronises two pads via IPFS (126488ms)

Test Suites: 1 failed, 1 total
Tests:       2 failed, 2 total
Snapshots:   0 total
Time:        255.364s
Ran all test suites.

Additionally this error appeared in the console:

screen shot 2018-07-28 at 21 17 08

In slightly better news, I manually ran a smoke test with the development server. I started two browser instances and loaded a document. Changes on both sides were reflected on the other with no errors.

@pgte
Copy link
Contributor

pgte commented Jul 29, 2018

Hi Alan, thank you for your troubles, but peer-pad-core is no longer being used in peer-pad.
Instead, peer-pad is using peer-star-app, which looks to be working great. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants