Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't run tests on windows #159

Closed
victorb opened this issue Oct 19, 2017 · 5 comments
Closed

Can't run tests on windows #159

victorb opened this issue Oct 19, 2017 · 5 comments
Assignees
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@victorb
Copy link
Member

victorb commented Oct 19, 2017

Currently trying to run the js-ipfs-api tests with aegir but doesn't work since Jest doesn't find any of the test files. I'm guessing this is because there is some hardcoded / instead of using path.join and I tried some quick hacks to fix it, but didn't manage to solve it.

image

Opening this issue so I can get back it later.

@victorb victorb added the kind/bug A bug in existing code (including security flaws) label Oct 19, 2017
@victorb victorb self-assigned this Oct 19, 2017
@dignifiedquire
Copy link
Member

This should make it easier to ensure things are working on windows here: #161

@dignifiedquire
Copy link
Member

I suspect the problem are these patterns here: https://github.com/ipfs/aegir/blob/master/src/test/node.js#L25-L26 which are not matching \ only /.

@daviddias
Copy link
Member

@victorbjelkholm is this still an issue? @richardschneider pretty much solved all the Windows issue I believe

@victorb
Copy link
Member Author

victorb commented Jan 24, 2018

This is now working.

@victorb victorb closed this as completed Jan 24, 2018
@daviddias
Copy link
Member

<3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Development

No branches or pull requests

3 participants