fix: upgrade eslint to v5 #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
N.b. needs to manually run patterns to lint through the glob module before linting until eslint/eslint#10587 is resolved.
achingbrain
force-pushed
the
upgrade-eslint-to-v5
branch
from
9b0dbf6
to
42a8925
Compare
hugomrdias
suggested changes
Nov 21, 2018
src/lint.js
Outdated
| @@ -4,6 +4,8 @@ const CLIEngine = require('eslint').CLIEngine | |||
| const path = require('path') | |||
| const formatter = CLIEngine.getFormatter() | |||
| const userConfig = require('./config/user') | |||
| const promisify = require('util').promisify | |||
| const glob = promisify(require('glob')) | |||
There was a problem hiding this comment.
can you pls change to https://www.npmjs.com/package/globby which already has a promise api and is based on https://github.com/mrmlnc/fast-glob which is faster than glob
hugomrdias
approved these changes
Nov 21, 2018
|
@hugomrdias thanks for merging - any chance of this being released? |
|
Sure I'll release it asap. On my phone right now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
N.b. needs to manually run patterns to lint through the glob module before linting until eslint/eslint#10587 is resolved.