fix: make babel and webpack safer and faster #305
Conversation
ghost
assigned 
| safari10: true | ||
| }, | ||
| output: { | ||
| ecma: 5, |
There was a problem hiding this comment.
Does this mean it is outputting ecma5 code?
There was a problem hiding this comment.
No this build outputs according to our default or repo browserlist support config !!
This setting means that any transformation applied by terser needs to be at least es5 compatible. Makes sense ? ES6+ code will not be converted to ES5 by terser but any change in the code made by terser needs to be es5 compatible.
| filename: `${pkg.name}.js`, | ||
| sourceMapFilename: `${pkg.name}.js.map` | ||
| filename: 'index.js', | ||
| sourceMapFilename: 'index.js.map' |
There was a problem hiding this comment.
I think the package name is a good default, but we should make this configurable to resolve #276 and allow JS IPFS to keep index.js.
There was a problem hiding this comment.
can we tackle this in another PR ? this keep the current behaviour and makes this PR easier to integrate. I need this for the bundle size PRs
This PR makes experimental babel/webpack config safer, faster and more compatible with the default one and bundle smaller.