feat: add bundlesize support to the build cmd #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
hugomrdias
requested review from
alanshaw,
achingbrain,
jacobheun and
vasco-santos
vasco-santos
requested changes
Feb 21, 2019
src/build/index.js
Outdated
| if (argv.bundlesize) { | ||
| return webpack | ||
| .then(r => { | ||
| return execa('bundlesize', ['-f', './dist/index.min.js', '-s', getUserConfig().bundlesize || '100kB'], { |
There was a problem hiding this comment.
What about having a constants.js for the defaults used in aegir?
We probably have more default constants such as this 100kB and it would be easier to have those all together. We can start with this one and move the remaining ones later?
jacobheun
approved these changes
Feb 21, 2019
hugomrdias
added a commit
to ipfs/js-ipfsd-ctl
that referenced
this pull request
Feb 21, 2019
This PR adds a workaround to the windows secrets problem
```
jobs:
include:
- os: windows
filter_secrets: false
```
because we need to give bundlesize a token but we **should be very careful with this**.
This disables the log secrets filtering making the token available if you echo the ENV var.
In this case is acceptable because the token only has access to commit_status in this repo.
needs:
[ipfs/aegir#feat/bundle-size](ipfs/aegir#335)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.