Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use the same timeout for mocha and karma-mocha #338

Merged
merged 1 commit into from
Mar 4, 2019

Conversation

hugomrdias
Copy link
Member

@vmx does this fix your issue in ipfs-bitswap ?

@hugomrdias hugomrdias requested a review from vmx March 4, 2019 16:44
@ghost ghost assigned hugomrdias Mar 4, 2019
@ghost ghost added the status/in-progress In progress label Mar 4, 2019
@vmx
Copy link
Member

vmx commented Mar 4, 2019

Tests have passed with this branch. So it looks like it's the right setting.

Though it shouldn't be hard-coded to 5s, but it should take the value that aegir was configured with.

@hugomrdias
Copy link
Member Author

from the cli ? like npx aegir test -t browser --timeout 5000 ?

@vmx
Copy link
Member

vmx commented Mar 4, 2019

Yes that's what I meant.

@hugomrdias hugomrdias marked this pull request as ready for review March 4, 2019 19:08
@hugomrdias
Copy link
Member Author

yes ofc i have on my todo a task to normalize all these issues.
lets merge this to get you rolling and ill get to that later ok ?

@vmx
Copy link
Member

vmx commented Mar 4, 2019

That's fine with me!

@hugomrdias hugomrdias merged commit 58fb8b0 into master Mar 4, 2019
@ghost ghost removed the status/in-progress In progress label Mar 4, 2019
@hugomrdias hugomrdias deleted the fix/karma-mocha-timeout branch March 4, 2019 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants