You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
IMO it seems strange to have transpiled javascript in a different directory than src/. The reason is that aegir-maintained libp2p repos (non-typescript repos) expect javascript source files to be in src, and submodules are sometimes directly imported like eg: require('libp2p-xxx/src/submodule')). If typescript aegir-maintained projects are to maximally maintain compatibility with non-typescript aegir-maintained projects, it seems that we would want to maintain this project structure?
IMO it seems strange to have transpiled javascript in a different directory than
src/
. The reason is that aegir-maintained libp2p repos (non-typescript repos) expect javascript source files to be insrc
, and submodules are sometimes directly imported like eg:require('libp2p-xxx/src/submodule')
). If typescript aegir-maintained projects are to maximally maintain compatibility with non-typescript aegir-maintained projects, it seems that we would want to maintain this project structure?Originally posted by @wemeetagain in https://github.com/_render_node/MDIzOlB1bGxSZXF1ZXN0UmV2aWV3VGhyZWFkMjc1ODE3ODM5OnYy/pull_request_review_threads/discussion
The text was updated successfully, but these errors were encountered: