-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ipfs/go-ipfs-files] Fix encoding of filename in Content-Disposition #29
Comments
Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
Finally, remember to use https://discuss.ipfs.io if you just need general support. |
@Stebalien do you mean in multiFileReader? The filename is encoded using url.QueryEscape so should be encoded according to standards. Test added in this commit: 66d91bf (#34) Does this ticket remain an issue? |
I can't remember at this point. If that's where we set Content-Disposition, then yes. |
Yes, that's the only place it is set, since all values are escaped using url.QueryEscape this ticket is probably stale and could be closed. |
We should use RFC5987 to encode the filename in the Content-Disposition header. GO will already gracefully handle line-breaks but we should still be escaping better.
The text was updated successfully, but these errors were encountered: