Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

files(ShouldExclude): compatibility with gitignore #648

Open
lidel opened this issue Jul 30, 2024 · 0 comments
Open

files(ShouldExclude): compatibility with gitignore #648

lidel opened this issue Jul 30, 2024 · 0 comments
Labels
dif/medium Prior experience is likely helpful effort/days Estimated to take multiple days, but less than a week help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P3 Low: Not priority right now

Comments

@lidel
Copy link
Member

lidel commented Jul 30, 2024

Bug extracted from #516, my rough understanding is:

  • The current implementation ShouldExclude is not fully compatible with https://git-scm.com/docs/gitignore.

    • [There is an] issue where bar/ didn't catch directories. [Both] bar and bar/ rules [should] filter out the bar directory and its contents.

    • To be fully compatible, the paths have to be matched against a relative path, right now it's just a file name.
@lidel lidel added P3 Low: Not priority right now dif/medium Prior experience is likely helpful effort/days Estimated to take multiple days, but less than a week help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) labels Jul 30, 2024
@lidel lidel mentioned this issue Jul 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dif/medium Prior experience is likely helpful effort/days Estimated to take multiple days, but less than a week help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P3 Low: Not priority right now
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lidel