Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signed commits #147

Closed
daviddias opened this issue Aug 1, 2016 · 3 comments
Closed

Signed commits #147

daviddias opened this issue Aug 1, 2016 · 3 comments
Assignees

Comments

@daviddias
Copy link
Member

go-ipfs has a long running best practice of requesting their contributors to sign their commits -- https://github.com/ipfs/community/blob/master/contribution-guidelines.md#a-license-and-a-signed-off-by-trailers-are-required --, since it is the same project, we should do that for js-ipfs, libp2p and all their modules.

In fact, I even created a module just to run the bash script (I kept looking for it) https://www.npmjs.com/package/sign-commit

Thoughts?

@RichardLitt could you help us set up this guideline for the js ecosystem? Thank you :)

@dignifiedquire
Copy link
Member

@jbenet answered this here: ipfs/distributions#76 so lets figure out the best steps to ensure this happens everywhere, including setting up validation.

@daviddias
Copy link
Member Author

ping @RichardLitt

@RichardLitt RichardLitt self-assigned this Jan 13, 2017
@daviddias
Copy link
Member Author

This is now part of #253

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants