Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails on macos due to unsupported comm flag --nocheck-order #350

Closed
olizilla opened this issue May 28, 2021 · 3 comments
Closed

Build fails on macos due to unsupported comm flag --nocheck-order #350

olizilla opened this issue May 28, 2021 · 3 comments
Labels

Comments

@olizilla
Copy link
Member

The version of comm that ships with macos does not support the --nocheck-order flag which got added in 19448fd

so macos users get

** fs-repo-0-to-1 **
/Library/Developer/CommandLineTools/usr/bin/make -C dists/fs-repo-0-to-1
../../build-go.sh "fs-repo-0-to-1" "github.com/ipfs/fs-repo-migrations" "fs-repo-0-to-1" versions
comparing versions with /ipfs/QmUeJDaHiaETrpyqaydtp5Fgbkayz6qxkJ7n2Ddyi4pbpq/fs-repo-0-to-1/versions
comm: illegal option -- -
usage: comm [-123i] file1 file2
make[1]: *** [dist] Error 1
make: *** [fs-repo-0-to-1] Error 2
@olizilla olizilla added the need/triage Needs initial labeling and prioritization label May 28, 2021
@olizilla
Copy link
Member Author

This is so dull. This should probably be dockerized.

@aschmahmann
Copy link
Contributor

aschmahmann commented May 28, 2021

@olizilla note that building in docker is almost certainly a good idea given #348 as well as #322 (and issues related to different binary dependency versions like node, npm, jq, awk, etc.)

@thattommyhall thattommyhall mentioned this issue Jun 2, 2021
@lidel lidel added status/in-progress In progress and removed need/triage Needs initial labeling and prioritization labels Jun 18, 2021
@lidel
Copy link
Member

lidel commented Aug 4, 2021

Closed by #352 and #367
TLDR: run ./dockerized make foo or ./dockerized ./dist.sh foo

@lidel lidel closed this as completed Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants