Skip to content
This repository has been archived by the owner on Feb 1, 2023. It is now read-only.

Session should broadcast when all peers are removed #259

Closed
dirkmc opened this issue Feb 14, 2020 · 0 comments · Fixed by #272
Closed

Session should broadcast when all peers are removed #259

dirkmc opened this issue Feb 14, 2020 · 0 comments · Fixed by #272

Comments

@dirkmc
Copy link
Contributor

dirkmc commented Feb 14, 2020 •
edited
Loading

The Session keeps a list of peers that it sends wants to. Peers can timeout or disconnect. The Session should broadcast a request for a subset of CIDs if

  • the last peer in the Session becomes unavailable
  • a peer is removed from the Session where
    • all other peers in the Session had sent DONT_HAVE
    • only this peer had not yet responded
@dirkmc dirkmc mentioned this issue Jan 27, 2023
Open
@dirkmc dirkmc changed the title SessionWantSender should broadcast when all peers are removed Session should broadcast when all peers are removed Feb 14, 2020
This was referenced Jan 27, 2023
Open
Closed
@dirkmc dirkmc mentioned this issue Feb 28, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure broadcast when remaining peer becomes unavailable ipfs/go-bitswap
1 participant
@dirkmc