Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup BasicBlock constructors #44

Open
Stebalien opened this issue Jun 21, 2017 · 0 comments
Open

Cleanup BasicBlock constructors #44

Stebalien opened this issue Jun 21, 2017 · 0 comments

Comments

@Stebalien
Copy link
Member

  1. NewBlock should take a cid.Prefix.
  2. NewBlockWithCid should not return an error, it should panic if the CID doesn't match and we're in debug mode.

This may cause a bit of code churn...
@Jorropo Jorropo changed the title Cleanup BasicBlock constructors [ipfs/go-block-format] Cleanup BasicBlock constructors Jan 26, 2023
@Jorropo Jorropo transferred this issue from ipfs/go-block-format Jan 26, 2023
@hacdias hacdias transferred this issue from ipfs/boxo Jun 29, 2023
@hacdias hacdias changed the title [ipfs/go-block-format] Cleanup BasicBlock constructors Cleanup BasicBlock constructors Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Stebalien