Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract non-core functionaly into new package #68

Closed
kevina opened this issue Aug 14, 2018 · 5 comments
Closed

Extract non-core functionaly into new package #68

kevina opened this issue Aug 14, 2018 · 5 comments
Assignees

Comments

@kevina
Copy link
Contributor

kevina commented Aug 14, 2018

go-cid is used by any package that does anything IPFS or IPLD related. we should probably move non-core functionally into a new package to avoid having to update so many packages when non-core functionality changes.

Code in the following packages should likely be moved:

  • set.go and tests
  • format.go and tests
  • Everything in cid-fmt/.
@kevina
Copy link
Contributor Author

kevina commented Aug 16, 2018

@Stebalien you didn't want to extract set.go, what parts did you want to extract to go-cidutil? Do you want to move StreamingSet?

@Stebalien
Copy link
Member

For now, let's leave set.go (well, the Set structure in set.go). However, feel free to move StreamingSet. Given that it's a "new" feature, feel free to "move" it by recommitting it to the new repo (just make sure to set the commit author to magik6k).

@Stebalien
Copy link
Member

I would move format.go and cid-fmt (and the Identity cid builder).

@kevina
Copy link
Contributor Author

kevina commented Aug 16, 2018

Okay. Just how many packages use cid.Set?

The Identity cid builder will come imminently after the extraction and I will make a p.r. for it.

@Stebalien
Copy link
Member

ipfs, bitswap, filecoin. I'm not really worried about breaking our code, I just don't want to mass-break other people's code (yet).

@ghost ghost assigned kevina Aug 17, 2018
@ghost ghost added the status/in-progress In progress label Aug 17, 2018
@ghost ghost removed the status/in-progress In progress label Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants