Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nodes without any heads should not build on top of unsynced branches #199

Open
hsanjuan opened this issue Mar 28, 2023 · 0 comments
Open
Labels
need/triage Needs initial labeling and prioritization

Comments

@hsanjuan
Copy link
Collaborator

This code here:

https://github.com/ipfs/go-ds-crdt/blob/master/crdt.go#L379-L401

was well intentioned, but it can be a bit of a footgun as it risks building on top of irretrievable DAGs branches that other nodes may be broadcasting, something we generally want to avoid so that they don't become blockers to progress.

Instead, new nodes can build on their own branch until they sync and set-heads in a normal fashion. The only consideration would be that the height they use should be probably set to the highest seen one even if we haven't finished syncing such a branch.

@hsanjuan hsanjuan added the need/triage Needs initial labeling and prioritization label Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/triage Needs initial labeling and prioritization
Projects
None yet
Development

No branches or pull requests

1 participant