Skip to content
This repository has been archived by the owner on Feb 7, 2024. It is now read-only.

support for "pin ls --type ..." #237

Closed
MichaelMure opened this issue Mar 15, 2021 · 0 comments · Fixed by #240
Closed

support for "pin ls --type ..." #237

MichaelMure opened this issue Mar 15, 2021 · 0 comments · Fixed by #240
Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked

Comments

@MichaelMure
Copy link
Contributor

Unless I'm missing something, specifying the type of pin you want to list with Shell.Pins() is not supported. Same for Shell.PinsStream().

It would be useful though, in particular if you only care about the recursive ones. Listing all the indirect pins can be excessively slow and wasteful, and incur a large processing overhead on the node.
@MichaelMure MichaelMure added the need/triage Needs initial labeling and prioritization label Mar 15, 2021
@aschmahmann aschmahmann added status/ready Ready to be worked help wanted Seeking public contribution on this issue P2 Medium: Good to have, but can wait until someone steps up effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up and removed need/triage Needs initial labeling and prioritization labels Mar 15, 2021
@ani1311 ani1311 mentioned this issue Apr 14, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added Type field for Pin ls command ani1311/go-ipfs-api
2 participants
@MichaelMure @aschmahmann