Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow NoRemote/NoLocal to be configured on a per-run basis #218

Open
schomatis opened this issue Sep 13, 2021 · 0 comments
Open

Allow NoRemote/NoLocal to be configured on a per-run basis #218

schomatis opened this issue Sep 13, 2021 · 0 comments
Labels
need/triage Needs initial labeling and prioritization

Comments

@schomatis
Copy link
Contributor

go-ipfs-cmds/command.go

Lines 94 to 98 in 87b5c50

// NoRemote denotes that a command cannot be executed in a remote environment
NoRemote bool
// NoLocal denotes that a command cannot be executed in a local environment
NoLocal bool

At the moment these configurations apply on a per-command basis. For some specific cases of go-ipfs commands it might be valuable to configure them on a per-run basis depending on the arguments the command is being run with.

More background (see also ipfs/kubo#8131): ipfs files write command can be run either locally or remotely but when specified with the --flush=false flag it should be run only remotely or fail to make sure the flush doesn't take place.

@schomatis schomatis added the need/triage Needs initial labeling and prioritization label Sep 13, 2021
@BigLep BigLep added this to the Best Effort Track milestone Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/triage Needs initial labeling and prioritization
Projects
No open projects
Status: No status
Development

No branches or pull requests

2 participants