Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handle ResponseEmitter closure in Emit #69

Open
Stebalien opened this issue Mar 4, 2018 · 0 comments
Open

Better handle ResponseEmitter closure in Emit #69

Stebalien opened this issue Mar 4, 2018 · 0 comments

Comments

@Stebalien
Copy link
Member

We need to make it clear whether the emitter is simply closed (and the sender should go away) or something actually went wrong.

Really, we should probably just log what went wrong and return a boolean where false means "closed". Currently, we return an error but it's unclear how this error should be handled. Should the caller follow up with a SetError call? (the answer is no but the API is really unclear).


Also, we need to make sure that all emitters handle context cancellation correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant