-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Writing to stderr from CLI encoder #70
Comments
Unfortunately, we've completely mixed CLI encoding with encoding for transport (HTTP, writer, etc.) so fixing this won't be fun at all. |
So, I tried using a PostRun to fix this (splitting out errors from non-errors in the post run). However, it turns out that correctly handling errors from |
One solution is to return the error as an error from the encoder. However, we'll need to modify the encoding logic to continue when it encounters an error. |
So, the old interface provided access to stderr. The new one assumes that all values emitted should go to stdout. It assumes that all errors should be returned via
SetError
. Unfortunately, this makes it impossible to migrate some commands without breaking the API.Also, as I've stated in #62, I'd like to just use
SetError
for terminal errors. That is, "status" errors are just output.The text was updated successfully, but these errors were encountered: