Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gx: update go-ipfs-cmds #4975

Merged
merged 1 commit into from
Apr 26, 2018
Merged

gx: update go-ipfs-cmds #4975

merged 1 commit into from
Apr 26, 2018

Conversation

djdv
Copy link
Contributor

@djdv djdv commented Apr 24, 2018 •
edited
Loading

Blocked on: ipfs/go-ipfs-cmds#104
Resolves: #3266

@djdv
gx: update go-ipfs-cmds
b675ade 
License: MIT
Signed-off-by: Dominic Della Valle <ddvpublic@gmail.com>
@djdv djdv added the status/blocked Unable to be worked further until needs are met label Apr 24, 2018
@djdv djdv requested a review from Kubuxu as a code owner April 24, 2018 19:08
@ghost ghost assigned djdv Apr 24, 2018
@ghost ghost added the status/in-progress In progress label Apr 24, 2018
@djdv
Copy link
Contributor Author

djdv commented Apr 24, 2018

For reference this is still an (unresolved) issue
#1394

@djdv djdv removed the status/blocked Unable to be worked further until needs are met label Apr 24, 2018
whyrusleeping
whyrusleeping approved these changes Apr 26, 2018
View reviewed changes
Copy link
Member

@whyrusleeping whyrusleeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes that only affect windows (also includes a bugfix for something that doesnt affect anything in go-ipfs).

@whyrusleeping whyrusleeping merged commit 9abf485 into ipfs:master Apr 26, 2018
@ghost ghost removed the status/in-progress In progress label Apr 26, 2018
hacdias pushed a commit to ipfs/boxo that referenced this pull request Jan 27, 2023
@whyrusleeping
Merge pull request ipfs/kubo#4975 from djdv/gx/go-ipfs-cmds
cb885fd 
gx: update go-ipfs-cmds

This commit was moved from ipfs/kubo@9abf485
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whyrusleeping whyrusleeping whyrusleeping approved these changes

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

Assignees

@djdv djdv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djdv @whyrusleeping