Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix node construction queue error #6480

Merged
merged 3 commits into from
Jul 3, 2019
Merged

Fix node construction queue error #6480

merged 3 commits into from
Jul 3, 2019

Conversation

michaelavila
Copy link
Contributor

@michaelavila michaelavila commented Jul 1, 2019 •
edited
Loading

Fixes #6467, by implementing a very simple version of #6260.

@michaelavila michaelavila force-pushed the bugs/node-construction-queue-error branch 2 times, most recently from dc37657 to 6e6a7c3 Compare July 1, 2019 18:52
@michaelavila michaelavila changed the title [WIP] [DO NOT REVIEW] Fix node construction queue error Fix node construction queue error Jul 1, 2019
@michaelavila michaelavila marked this pull request as ready for review July 1, 2019 20:10
@michaelavila michaelavila added topic/provider Topic provider need/review Needs a review labels Jul 1, 2019
@michaelavila michaelavila removed the need/review Needs a review label Jul 1, 2019
@michaelavila michaelavila changed the title Fix node construction queue error [DO NOT REVIEW] Fix node construction queue error Jul 1, 2019
@michaelavila michaelavila force-pushed the bugs/node-construction-queue-error branch 2 times, most recently from 153b839 to 07c7e0e Compare July 2, 2019 16:23
@michaelavila michaelavila changed the title [DO NOT REVIEW] Fix node construction queue error Fix node construction queue error Jul 2, 2019
@michaelavila michaelavila added the need/review Needs a review label Jul 2, 2019
@michaelavila michaelavila requested a review from Stebalien July 2, 2019 16:34
@michaelavila michaelavila mentioned this pull request Jul 2, 2019
Closed
@michaelavila michaelavila force-pushed the bugs/node-construction-queue-error branch from 07c7e0e to 2ef67c9 Compare July 2, 2019 16:50
Stebalien
Stebalien requested changes Jul 2, 2019
View reviewed changes
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo the limit (ensures we avoid doing unecessary work) and the abse32 encoding

provider/queue/queue.go Show resolved Hide resolved
provider/queue/queue.go Outdated Show resolved Hide resolved
provider/queue/queue.go Show resolved Hide resolved
provider/queue/queue.go
@@ -124,7 +80,26 @@ func (q *Queue) work() {

for {
if c == cid.Undef {
k, c = q.nextEntry()
head, e := q.getQueueHead()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, we'd:

  1. Open a query.
  2. Iterate over the query to the end.
  3. Open a new query when we get the next CID.

(but we can punt on that)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got you. I'll keep that in mind.

@michaelavila michaelavila force-pushed the bugs/node-construction-queue-error branch from 1ff9d53 to 143e415 Compare July 3, 2019 17:02
@michaelavila
Copy link
Contributor Author

@Stebalien this should be good to go.

@Stebalien Stebalien merged commit eca93bc into master Jul 3, 2019
@michaelavila michaelavila deleted the bugs/node-construction-queue-error branch July 3, 2019 19:54
@michaelavila michaelavila mentioned this pull request Jul 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

Assignees
No one assigned
Labels
need/review Needs a review topic/provider Topic provider
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Could not build arguments for function "reflect".makeFuncStub
2 participants
@michaelavila @Stebalien