Update to go-libp2p 0.6.0 #6914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
6 tasks
This is just the part about parsing the 3-line private network key file right? Are we sure this was not used outside of IPFS? It is going to be hard for people to find it (and use it) if they were relying on it. Might consider keeping and marking as deprecated in libp2p land? |
|
@hsanjuan has a good point. We might as well keep the decoding code, at least, in go-libp2p-pnet so others can use it. |
|
Please don't move deserialization here. This will give me another repository I need to fork and manage. This is libp2p functionality, please have it stay as such. |
Stebalien
reviewed
Mar 3, 2020
Stebalien
force-pushed
the
generalize-private-network
branch
2 times, most recently
from
0daef82
to
8d2bdfd
Compare
Stebalien
force-pushed
the
generalize-private-network
branch
from
8d2bdfd
to
53782d4
Compare
Stebalien
approved these changes
Mar 10, 2020
Stebalien
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves a bunch of code remove from go-libp2p-pnet to go-ipfs. This is necessary due to the change in the private network interface (see libp2p/go-libp2p#795).