integration test for the dual dht #7151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
willscott
force-pushed
the
feat/dual-dht-tests
branch
2 times, most recently
from
764b8be to
4895adc
Compare
|
the test now passes locally when run with a go-libp2p containing the fix from libp2p/go-libp2p#887 |
willscott
force-pushed
the
feat/dual-dht-tests
branch
from
fa2738d to
e5a4187
Compare
Stebalien
approved these changes
Apr 15, 2020
| }) | ||
|
|
||
| testPeer, err := core.NewNode(ctx, &core.BuildCfg{ | ||
| Online: true, |
There was a problem hiding this comment.
We should start the test peer as a client. Otherwise, the test record could get put on the test peer.
| _ = testPeer.PeerHost.Network().ClosePeer(lanPeers[i].Identity) | ||
| testPeer.PeerHost.Peerstore().ClearAddrs(lanPeers[i].Identity) | ||
| } | ||
| } |
There was a problem hiding this comment.
Now that we're trying to find a record, not a peer, this shouldn't be necessary.
| _ = testPeer.PeerHost.Network().ClosePeer(wanPeers[i].Identity) | ||
| testPeer.PeerHost.Peerstore().ClearAddrs(wanPeers[i].Identity) | ||
| } | ||
| } |
There was a problem hiding this comment.
ditto. Now that we're calling FindProviders instead of FendPeer, disconnecting doesn't buy us anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an integration test.
Currently, an
*IpfsDHTis exposed by the core, which will not be populated due to the use of thedualDHT. this test will not be able to refresh the routing table as a result, and will fail at present on thefeat/dual-dhtbranch.