fix: subdomain redirect for dir CIDs #7165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
commented
Apr 15, 2020
Closes #7164 License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
lidel
force-pushed
the
fix/subdomain-dir-redirect
branch
from
5ee1295 to
8290ec1
Compare
Stebalien
approved these changes
Apr 15, 2020
hacdias
pushed a commit
to ipfs/boxo
that referenced
this pull request
Jan 27, 2023
fix: subdomain redirect for dir CIDs This commit was moved from ipfs/kubo@6f4608b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7164
Note: due to the way
httpin golang works, status code can be set only once.There is a known issue with
prometheus/client_golang: it sometimes producessuperfluous response.WriteHeader calland if it is executed first, the status code set in our code is ignored.In this PR I set the redirect status code before executing the template to avoid potential race condition, feels like the least invasive way of making this work reliably.