docs: note that ShardingEnabled is a global flag #7218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
People may assume that HAMT gets enabled only for directories over some arbitrary threshold. This is not the case. Right now it is a global setting which will impact the final CID of all directories produced by ipfs.add.
Stebalien
approved these changes
Apr 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a note about global side effect of setting
ShardingEnabledtotrueRight now it is a global setting which will impact the final CID of all directories produced by
ipfs.addPeople may assume that HAMT sharding gets enabled only for directories over some arbitrary threshold.
(I did. And took me a moment to understand why CID of WebUI is no longer reproducible. Embarrassingly long moment.. 😬 )
cc ipfs/interface-go-ipfs-core#48