Updates bash completions to be compatible with zsh #7261
Conversation
The `compopt` bash builtin is not supported by zsh's bash compatibility features. By checking for zsh presence and using `complete` instead, this script becomes suitable for use with both bash and zsh.
|
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
misc/completion/ipfs-completion.bash
Outdated
| if [ -n "$ZSH_VERSION" ]; then | ||
| complete $@ | ||
| else | ||
| compopt $@ | ||
| fi |
There was a problem hiding this comment.
| if [ -n "$ZSH_VERSION" ]; then | |
| complete $@ | |
| else | |
| compopt $@ | |
| fi | |
| if [[ $(type compopt) == *"builtin" ]]; then | |
| compopt $@ | |
| else | |
| complete $@ | |
| fi |
There was a problem hiding this comment.
perhaps do this by seeing which one is available, rather than an env var
There was a problem hiding this comment.
Edit: scratch that. I had a typo. Seems to work. 👍 I tried looking for something similar but couldn't find anything that worked in both bash and zsh. This suggestion does not work in zsh.
|
@willscott Updated based on your feedback. Thanks! |
The
compoptbash builtin is not supported by zsh's bash compatibilityfeatures. By checking for zsh presence and using
completeinstead,this script becomes suitable for use with both bash and zsh.