Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use t.Cleanup() to reduce the need to clean up servers in tests #7550

Merged
merged 1 commit into from
Aug 25, 2020

Conversation

trashhalo
Copy link
Contributor

@trashhalo trashhalo commented Jul 18, 2020

@welcome
Copy link

welcome bot commented Jul 18, 2020

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@aschmahmann
Copy link
Contributor

Thanks for the PR! I'll try and look at this next week.

Copy link
Contributor

@petar petar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aschmahmann aschmahmann merged commit bd08c0a into ipfs:master Aug 25, 2020
@aschmahmann
Copy link
Contributor

Thanks @trashhalo

@aschmahmann aschmahmann mentioned this pull request Sep 22, 2020
72 tasks
hacdias pushed a commit to ipfs/boxo that referenced this pull request Jan 27, 2023
use t.Cleanup() to reduce the need to clean up servers in tests

This commit was moved from ipfs/kubo@bd08c0a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants